Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix bundle version in libnpmpublish tests #6748

Merged
merged 1 commit into from
Aug 30, 2023
Merged

chore: fix bundle version in libnpmpublish tests #6748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion workspaces/libnpmpublish/test/fixtures/valid-bundle.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"mediaType": "application/vnd.dev.sigstore.bundle+json;version=0.1",
"mediaType": "application/vnd.dev.sigstore.bundle+json;version=0.2",
"verificationData": {
"tlogEntries": [
{
Expand Down
6 changes: 3 additions & 3 deletions workspaces/libnpmpublish/test/publish.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,7 @@ t.test('publish existing package with provenance in gha', async t => {
// Can't match length because in github actions certain environment
// variables are present that are not present when running locally,
// changing the payload size.
content_type: 'application/vnd.dev.sigstore.bundle+json;version=0.1',
content_type: 'application/vnd.dev.sigstore.bundle+json;version=0.2',
},
},
}
Expand Down Expand Up @@ -768,7 +768,7 @@ t.test('user-supplied provenance - success', async t => {
length: tarData.length,
},
'@npmcli/libnpmpublish-test-1.0.0.sigstore': {
content_type: 'application/vnd.dev.sigstore.bundle+json;version=0.1',
content_type: 'application/vnd.dev.sigstore.bundle+json;version=0.2',
data: /.*/, // Can't match against static value as signature is always different
length: 7927,
},
Expand Down Expand Up @@ -1035,7 +1035,7 @@ t.test('publish existing package with provenance in gitlab', async t => {
// Can't match length because in github actions certain environment
// variables are present that are not present when running locally,
// changing the payload size.
content_type: 'application/vnd.dev.sigstore.bundle+json;version=0.1',
content_type: 'application/vnd.dev.sigstore.bundle+json;version=0.2',
},
},
}
Expand Down