Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow new majors of node to be automatically considered supported #697

Closed
wants to merge 1 commit into from
Closed

allow new majors of node to be automatically considered supported #697

wants to merge 1 commit into from

Conversation

ljharb
Copy link
Contributor

@ljharb ljharb commented Jan 16, 2020

What / Why

New major versions of node shouldn't be reported as "too old" or unsupported, in the absence of an explicit "known broken" declaration.

Per #696 (comment)

@ljharb ljharb requested a review from a team as a code owner January 16, 2020 19:41
@ljharb ljharb mentioned this pull request Jan 16, 2020
Closed
@ljharb
Copy link
Contributor Author

ljharb commented Jan 16, 2020

I have no idea where the tests for this might be; happy to write some if I can be pointed in the right direction.

@mikemimik mikemimik added Community Enhancement new feature or improvement Release 6.x work is associated with a specific npm 6 release Release 7.x work is associated with a specific npm 7 release semver:minor new backwards-compatible feature labels Jan 29, 2020
@darcyclarke darcyclarke removed the Release 7.x work is associated with a specific npm 7 release label Feb 18, 2020
@darcyclarke
Copy link
Contributor

@ljharb This looks good although we may want to make a few changes. This will potentially land although we'll update the implementation a bit. Thanks!

@darcyclarke darcyclarke added this to the OSS - Sprint 4 milestone Feb 18, 2020
@darcyclarke darcyclarke self-requested a review February 18, 2020 17:34
@darcyclarke darcyclarke self-assigned this Feb 18, 2020
@darcyclarke darcyclarke mentioned this pull request Feb 18, 2020
Closed
@ljharb
Copy link
Contributor Author

ljharb commented Feb 18, 2020

@darcyclarke great! i'm happy to make the changes as well if comments are posted; either way's fine with me.

@darcyclarke darcyclarke removed this from the OSS - Sprint 4 milestone Feb 25, 2020
isaacs pushed a commit that referenced this pull request Feb 25, 2020
@ljharb @isaacs
allow new majors of node to be automatically considered supported
7b6f557 
PR-URL: #697
Credit: @ljharb
Close: #697
Reviewed-by: @isaacs
isaacs pushed a commit that referenced this pull request Feb 25, 2020
@ljharb @isaacs
allow new majors of node to be automatically considered supported
e34373f 
PR-URL: #697
Credit: @ljharb
Close: #697
Reviewed-by: @isaacs
@isaacs isaacs mentioned this pull request Feb 25, 2020
Closed
@ljharb ljharb deleted the fix_supported_version_logic branch February 25, 2020 23:47
@isaacs isaacs mentioned this pull request Feb 27, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 10, 2020
Open
This was referenced Mar 18, 2020
Open
Open
Open
Open
Open
This was referenced Mar 20, 2020
Open
Open
Open
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Open
This was referenced Apr 8, 2020
Merged
Open
Open
This was referenced Apr 17, 2020
Open
Open
Open
This was referenced Feb 11, 2024
Open
Open
@EMWickd EMWickd mentioned this pull request Feb 11, 2024
Open
@Billywildhig Billywildhig mentioned this pull request Feb 11, 2024
Open
@311821105 311821105 mentioned this pull request Feb 11, 2024
Open
@Billywildhig Billywildhig mentioned this pull request Feb 11, 2024
Open
@hojatA1 hojatA1 mentioned this pull request Feb 11, 2024
Open
@EMWickd EMWickd mentioned this pull request Feb 11, 2024
Open
This was referenced Feb 12, 2024
Open
Open
@nicholaschoi168 nicholaschoi168 mentioned this pull request Feb 12, 2024
Open
@f4lco0n f4lco0n mentioned this pull request Feb 12, 2024
Open
@EMWickd EMWickd mentioned this pull request Feb 12, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Oct 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darcyclarke darcyclarke Awaiting requested review from darcyclarke

Assignees

@darcyclarke darcyclarke

Labels
Enhancement new feature or improvement Release 6.x work is associated with a specific npm 6 release semver:minor new backwards-compatible feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ljharb @darcyclarke @mikemimik