fix(arborist): node.target can be null when it is a file dep or symlink
#7027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately the test is The Thing for this bug. Many PRs have been started but none provides a test that shows the root cause. Without that we're just fixing it by accident. We have to know why this happens to know if this fix is the right one. |
lukekarrys
reviewed
Dec 2, 2023
lukekarrys
reviewed
Dec 2, 2023
workspaces/arborist/test/fixtures/reify-cases/conflict-bundle-file-dep.js
Show resolved
Hide resolved
lukekarrys
reviewed
Dec 2, 2023
workspaces/arborist/test/fixtures/reify-cases/conflict-bundle-file-dep.js
Show resolved
Hide resolved
lukekarrys
reviewed
Dec 2, 2023
wraithgar
approved these changes
Dec 6, 2023
|
<3 thank you! |
Merged
ljharb
added a commit
to ljharb/cli
that referenced
this pull request
Dec 6, 2023
…ymlink (npm#7027) Co-authored-by: Luke Karrys <luke@lukekarrys.com>
|
Created #7059 for v9. |
ljharb
added a commit
to ljharb/cli
that referenced
this pull request
Dec 8, 2023
Followup to npm#7027
This was referenced Dec 8, 2023
ljharb
added a commit
to ljharb/cli
that referenced
this pull request
Dec 16, 2023
Followup to npm#7027
ljharb
added a commit
to ljharb/cli
that referenced
this pull request
Jan 16, 2024
Followup to npm#7027
ljharb
added a commit
to ljharb/cli
that referenced
this pull request
Jan 18, 2024
Followup to npm#7027
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids a
Cannot read properties of null (reading 'realpath')error when installing a tree that contains, eg, https://npmjs.com/has-package-exports which has a file dep in it.May relate to other issues with similar errors; I'm happy to add a test but I'm not sure how to repro it outside of my project.
(I'll want to backport this as far back as possible once it lands in 10, so a test would be quite helpful to have)