npm-profile, npm-registry-fetch, emit input.start #7457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukekarrys
force-pushed
the
lk/help-and-url-input-start
branch
2 times, most recently
from
f66808b
to
5b230c7
Compare
lukekarrys
force-pushed
the
lk/help-and-url-input-start
branch
3 times, most recently
from
8aac32d
to
2f08cd7
Compare
lukekarrys
force-pushed
the
lk/help-and-url-input-start
branch
from
2f08cd7
to
19175d8
Compare
lukekarrys
force-pushed
the
lk/help-and-url-input-start
branch
from
19175d8
to
531c674
Compare
lukekarrys
changed the title
wraithgar
reviewed
May 2, 2024
| @@ -95,13 +95,15 @@ class Help extends BaseCommand { | |||
| args = ['emacsclient', ['-e', `(woman-find-file '${man}')`]] | |||
| } | |||
|
|
|||
| return spawn(...args, { stdio: 'inherit' }).catch(err => { | |||
There was a problem hiding this comment.
npm was not using the return data from promise-spawn here so this is ok
wraithgar
reviewed
May 2, 2024
| @@ -63,7 +63,7 @@ t.test('open bugs urls & emails', async t => { | |||
| const { npm } = await loadMockNpm(t, { | |||
| mocks: { | |||
| pacote, | |||
| '{LIB}/utils/open-url.js': openUrl, | |||
| '{LIB}/utils/open-url.js': { openUrl }, | |||
There was a problem hiding this comment.
in the future we should use spawk for these
wraithgar
reviewed
May 2, 2024
| t.same(joinedOutput(), '', 'printed no output') | ||
| }) | ||
| const { openUrlPrompt } = tmock(t, '{LIB}/utils/open-url.js', { | ||
| '@npmcli/promise-spawn': { |
There was a problem hiding this comment.
in the future we should use spawk here.
wraithgar
approved these changes
May 2, 2024
This also refactors auth and prompt related files to use promises and new npm-profile behavior
lukekarrys
force-pushed
the
lk/help-and-url-input-start
branch
from
9c5075c
to
8f73741
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this relies on npm/npm-profile#131This now includesnpm-profile@10.0.0This PR accomplishes the following:
input.startso progress won't be shown while the terminal is running those commandsotpleasetoauth.js. They share many of the same requires and all the commands that requiredauth.jsalso requiredotpleaseopen-urlandopen-url-promptfilesweb-authin favor of a newwebAuthOpenermethod exported fromnpm-profilereadline/promisesfor url prompts which can directly accept the new AbortSignal API fromnpm-profile