Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds node: specifier to all native node modules #7559

Merged
merged 13 commits into from
May 28, 2024
Merged

Conversation

reggi
Copy link
Contributor

@reggi reggi commented May 24, 2024

No description provided.

@reggi reggi requested a review from a team as a code owner May 24, 2024 16:57
@reggi reggi changed the title Adds node: specifier to all native node modules chore: adds node: specifier to all native node modules May 24, 2024
@wraithgar
Copy link
Member

This is a fix since it affects actual code and not just tests.

@npm-cli-bot
Copy link
Collaborator

npm-cli-bot commented May 24, 2024

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only modules-only no-lock no-cache no-modules no-clean show-version run-script cache-only
peer-deps
no-clean
audit
npm@latest 28.623 ±0.05 10.902 ±0.16 11.979 ±0.05 1.578 ±0.01 1.578 ±0.02 1.288 ±0.01 8.444 ±0.01 1.301 ±0.01 0.137 ±0.00 0.167 ±0.00 14.926 ±0.05 2.123 ±0.04
#7559 28.296 ±1.18 11.017 ±0.06 11.974 ±0.08 1.616 ±0.01 1.581 ±0.01 1.299 ±0.02 8.634 ±0.03 1.330 ±0.03 0.141 ±0.00 0.165 ±0.00 15.418 ±0.03 2.156 ±0.03
app-medium clean lock-only cache-only modules-only no-lock no-cache no-modules no-clean show-version run-script cache-only
peer-deps
no-clean
audit
npm@latest 22.497 ±0.15 8.310 ±0.13 9.302 ±0.12 1.599 ±0.00 1.547 ±0.02 1.533 ±0.13 5.972 ±0.05 1.361 ±0.03 0.143 ±0.00 0.175 ±0.00 10.159 ±0.02 2.020 ±0.03
#7559 22.663 ±0.60 8.207 ±0.12 9.051 ±0.01 1.540 ±0.00 1.549 ±0.02 1.447 ±0.01 5.940 ±0.07 1.341 ±0.01 0.143 ±0.00 0.168 ±0.00 10.090 ±0.05 2.271 ±0.33

@reggi reggi changed the title chore: adds node: specifier to all native node modules fix: adds node: specifier to all native node modules May 24, 2024
@reggi reggi merged commit 2d1d8d0 into latest May 28, 2024
210 checks passed
@reggi reggi deleted the reggi/node-specifier branch May 28, 2024 17:39
@github-actions github-actions bot mentioned this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants