fix(publish): skip workspace packages marked private on publish #7564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milaninfy
commented
May 29, 2024
| @@ -127,6 +127,15 @@ class Publish extends BaseCommand { | |||
| const noCreds = !(creds.token || creds.username || creds.certfile && creds.keyfile) | |||
| const outputRegistry = replaceInfo(registry) | |||
|
|
|||
| // if a workspace package is marked private then we skip it | |||
| if (workspace && manifest.private) { | |||
There was a problem hiding this comment.
Is there a better way to check if the package is workspace package ?
wraithgar
approved these changes
May 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm publish --workspaceswill skip workspace packages marked as private in package.json.Currently it's skipping those packages only when you have configured auth for those packages, it would error out with
ENEEDAUTHif it doesn't find the valid auth information.this fix checks for the private property before checking for auth for the packages that will essentially not going to get published.
Fixes #7199