Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue #7892 prevent package-lock.json creation without package.json #7960

Open
wants to merge 2 commits into
base: latest
Choose a base branch
from
Open

fix: issue #7892 prevent package-lock.json creation without package.json #7960

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01f92e0
fix: issue #7892 prevent package-lock.json creation without package.json
Kyle-Ignis Dec 5, 2024
01aab62
fix: issue:7892 prevent package-lock.json creation without package.json
Kyle-Ignis Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 20 additions & 14 deletions workspaces/arborist/bin/reify.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
const fs = require('node:fs')
const path = require('node:path')
const Arborist = require('../')

const printTree = require('./lib/print-tree.js')
Expand Down Expand Up @@ -30,19 +32,23 @@ const printDiff = diff => {
})
}

module.exports = (options, time) => {
module.exports = async (options, time) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, didn't catch that this was a bin, not part of the export. This doesn't actually change arborist itself. All this changes is npx -p @npmcli/arborist reify

Copy link
Author

@Kyle-Ignis Kyle-Ignis Dec 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain further or point me in the right direction?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's also not a breaking change (as long as the syntax is supported in all supported node's, which i believe it is), because the function already returns a promise.

// Check for package.json
if (!fs.existsSync(path.join(options.path, 'package.json'))) {
log.error('No package.json found in the current directory.')
log.error('Please navigate to the correct directory or run npm init.')
throw new Error('Aborted due to missing package.json')
}

const arb = new Arborist(options)
return arb
.reify(options)
.then(time)
.then(async ({ timing, result: tree }) => {
printTree(tree)
if (options.dryRun) {
printDiff(arb.diff)
}
if (tree.meta && options.save) {
await tree.meta.save()
}
return `resolved ${tree.inventory.size} deps in ${timing.seconds}`
})
const { timing, result: tree } = await arb.reify(options).then(time)

printTree(tree)
if (options.dryRun) {
printDiff(arb.diff)
}
if (tree.meta && options.save) {
await tree.meta.save()
}
return `resolved ${tree.inventory.size} deps in ${timing.seconds}`
}
Loading