Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #53

Closed
wants to merge 1 commit into from
Closed

Fix typo #53

wants to merge 1 commit into from

Conversation

idleberg
Copy link

I stumbled across this and thought about why you the file-extension was in place. I irritated my as it might others, so I think this has been a mistake and should be removed.

I might be wrong, but I don't think you want to show the file extension here
@npm-docs-robot
Copy link

👋 I'm your friendly documentation robot, and I'm going to build your pull request on our staging site so that you can review it. If you push up subsequent commits, I'll rebuild your staging area (and when this pull request is closed, I'll clean that staging area up).

I'll let you know when I'm done! 🤖

@npm-docs-robot
Copy link

👋 I've finished building this pull request on our staging site. 🤖

To see how it looks, visit: https://docs-staging.npmjs.com/53/

@MylesBorins
Copy link
Contributor

hey @idleberg this doc is actually vendored from the npm/cli repo so it would need to be updated there, not here.

With that said I don't think this is a change we would land. in the rendered documentation it is not longer a markdown file.

Closing this PR, but thank you for opening it!

@idleberg
Copy link
Author

Thanks @MylesBorins. I still think the fix is correct and explained it in more detail on that new PR: npm/cli#4081

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants