[feature] need a process undefined linting rule

[wraithgar]

Code that checks for the presence of process should test its type against undefined. Trying to access it AT ALL in a browser environment will throw an exception.

I don't know if a linting rule exists or if one needs to be written. But it should prevent things like:

if (process) {

or

if (process?.foo) {

[nlf]

i did a bit of searching and the best i came up with is disabling process as a global and leaning on the no-undef rule. the gotcha here is that actually using process in the places you need to means either disabling the no-undef rule for each line or referencing it as const process = require('process') which entirely possibly has its own browser related issues that it brings up

[wraithgar]

require('process') would make more issues in places where we currently work correctly I think, since bundlers would start needing to either shim or throw.

[nlf]

yeah, that's the issue with that approach for sure. adding a comment to disable the no-undef rule on the lines that you actually use process would work and avoids that problem, but is also kind of wonky feeling

[wraithgar]

Yeah it still wouldn't prevent process?.x which is the real thing we need to prevent. If it doesn't prevent that it's all just pretend anyways.

[voxpelli]

Using a types in js would catch this and feel more tuned into the job than eslint. Have you considered that?