fix: check process on browser #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
reviewed
May 4, 2023
wraithgar
reviewed
May 4, 2023
|
Hey @wraithgar can you take another look when you have time, please? Test coverage should now pass. |
|
I can't seem to find an eslint rule that covers this, sadly. I'm kind of surprised by this and hope it's my lack of search skills. Filed npm/eslint-config#70 for looking into it later. We typically don't like to fix things like this w/o making sure it doesn't happen again (cf npm/node-semver#554) |
wraithgar
approved these changes
May 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned on #199 (review), trying to access
processin a browser environment fails.The availability of the value needs to be checked before accessing it.
You can test this easily by running
process?.platformin the browser console. Instead of resolving to the expectedundefined, it throws an error.References
Relates to #199