Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set args to after-used for no-unused-vars rule #103

Merged
merged 1 commit into from
Apr 10, 2024
Merged

fix: set args to after-used for no-unused-vars rule #103

merged 1 commit into from
Apr 10, 2024

Conversation

lukekarrys
Copy link
Contributor

@lukekarrys lukekarrys commented Apr 10, 2024 •
edited
Loading

This PR makes the following code failing linting. IMO this helps with refactoring and making sure arguments are not left in function calls.

// Lint error: "'c' is defined but never used."
function unused (a, b, c) {
  return b
}
unused()

@lukekarrys lukekarrys requested a review from a team as a code owner April 10, 2024 19:44
@wraithgar wraithgar merged commit acd463d into main Apr 10, 2024
27 checks passed
@wraithgar wraithgar deleted the lk/after-used branch April 10, 2024 20:08
@github-actions github-actions bot mentioned this pull request Apr 10, 2024
Merged
wraithgar pushed a commit that referenced this pull request Apr 22, 2024
@github-actions
chore: release 4.0.3 (#97)
535d236 
🤖 I have created a release *beep* *boop*
---


## [4.0.3](v4.0.2...v4.0.3)
(2024-04-21)

### Bug Fixes

*
[`acd463d`](acd463d)
[#103](#103) set args to
after-used for no-unused-vars rule (#103) (@lukekarrys)
*
[`436f26c`](436f26c)
[#102](#102) don't enforce
max-len on comments (#102) (@wraithgar)

### Chores

*
[`f2706f7`](f2706f7)
[#104](#104) postinstall for
dependabot template-oss PR (@lukekarrys)
*
[`511b2b7`](511b2b7)
[#104](#104) bump
@npmcli/template-oss from 4.21.3 to 4.21.4 (@dependabot[bot])

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@YoutacRandS-VA YoutacRandS-VA mentioned this pull request Jun 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wraithgar wraithgar wraithgar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukekarrys @wraithgar