-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: smarter git ssh override #194
Conversation
CC @wraithgar possibly you can take a look as this issue is plauging many in the git/node community |
…udes and move dependancy
Having the tests look at the actual The code itself is looking good except for coverage, which my suggestion should hopefully fix. |
@wraithgar I dropped using |
Thanks for sticking with this @dennishenry. Testing this is not easy. I think we're very very close here. |
@wraithgar Should be good to go now! Let me know what you think and thanks so much for the partnership! |
@wraithgar Anything else you needed from me here? Just wanted to follow up. Thanks! |
Not at this time. Thanks for your patience here, other tasks have taken focus this month. |
🤖 I have created a release *beep* *boop* --- ## [5.0.8](v5.0.7...v5.0.8) (2024-07-09) ### Bug Fixes * [`2135513`](2135513) [#194](#194) smarter git ssh override (#194) (@dennishenry, pacotedev) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Removing the overwriting of git ssh commands. This should not be done, and should be left to individuals using their own ssh configs. This breaks multiple usecases.
Removing git ssh command that overrides local git ssh commands.
References
npm/cli#2891
#193
#129