Fix error when trying to publish repo

[sreeramjayan]

Fixes https://npm.community/t/npm-6-6-0-broke-authentication-with-npm-registry-couchapp/4752

[zkat]

Wow, what an oversight. Thank you so much for tracking this down and fixing it!

[pvdlg]

That PR didn't fix the bug.
See https://npm.community/t/npm-6-6-0-broke-authentication-with-npm-registry-couchapp/4752/5?u=pvdlg

[evocateur]

I think the underlying issue is that the conditional that wraps the _npmUser assignment isn't also checking for auth._auth, and if found, splitting the <username>:<password> field appropriately. I can't speak to the correctness of the "username" vs "name" property itself (although I suppose it should be what normalize-package-data does, so yes, name is the correct field AFAICT).

if (auth.username || auth.email || auth._auth) {
  manifest._npmUser = {
    name: auth.username || (auth._auth && auth._auth.split(':').shift()),
    email: auth.email,
  }
}

[pvdlg]

I don't know if username if recognized by the registry, but I can say for sure that name is because it's the way previous version of npm worked.

[zkat]

thanks for looking into this y'all. I'm working right this second on adding proper _auth support to npm-registry-fetch, where I think this should live.