Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: faster workspace mapping #143

Merged
merged 5 commits into from
Apr 10, 2024
Merged

fix: faster workspace mapping #143

merged 5 commits into from
Apr 10, 2024

Conversation

wraithgar
Copy link
Member

This is a cleanup of #138 to
get code coverage finished in the tests.

Credit: @thecodrr

@wraithgar wraithgar requested a review from a team as a code owner April 10, 2024 17:05
@wraithgar wraithgar merged commit c89a529 into main Apr 10, 2024
26 checks passed
@wraithgar wraithgar deleted the pr/138 branch April 10, 2024 17:18
@github-actions github-actions bot mentioned this pull request Apr 10, 2024
wraithgar pushed a commit that referenced this pull request Apr 10, 2024
🤖 I have created a release *beep* *boop*
---


##
[3.0.5](v3.0.4...v3.0.5)
(2024-04-10)

### Bug Fixes

*
[`c89a529`](c89a529)
[#143](#143) faster workspace
mapping (#143) (@wraithgar, @thecodrr)

### Documentation

*
[`304c345`](304c345)
[#141](#141) readme: fix
broken badge URLs (#141) (@10xLaCroixDrinker)

### Chores

*
[`2c3d889`](2c3d889)
[#137](#137) postinstall for
dependabot template-oss PR (@lukekarrys)
*
[`1e78272`](1e78272)
[#137](#137) bump
@npmcli/template-oss from 4.21.1 to 4.21.3 (@dependabot[bot])
*
[`a5b6bf5`](a5b6bf5)
[#134](#134) postinstall for
dependabot template-oss PR (@lukekarrys)
*
[`797d0a0`](797d0a0)
[#134](#134) bump
@npmcli/template-oss from 4.19.0 to 4.21.1 (@dependabot[bot])
*
[`4017779`](4017779)
[#115](#115) postinstall for
dependabot template-oss PR (@lukekarrys)
*
[`803e42f`](803e42f)
[#115](#115) bump
@npmcli/template-oss from 4.18.1 to 4.19.0 (@dependabot[bot])
*
[`b214753`](b214753)
[#114](#114) postinstall for
dependabot template-oss PR (@lukekarrys)
*
[`17747a7`](17747a7)
[#114](#114) bump
@npmcli/template-oss from 4.18.0 to 4.18.1 (@dependabot[bot])
*
[`ff82968`](ff82968)
[#113](#113) postinstall for
dependabot template-oss PR (@lukekarrys)
*
[`f38ff1e`](f38ff1e)
[#113](#113) bump
@npmcli/template-oss from 4.17.0 to 4.18.0 (@dependabot[bot])
*
[`cf234ce`](cf234ce)
[#112](#112) postinstall for
dependabot template-oss PR (@lukekarrys)
*
[`414331d`](414331d)
[#112](#112) bump
@npmcli/template-oss from 4.15.1 to 4.17.0 (@dependabot[bot])
*
[`003893e`](003893e)
[#110](#110) postinstall for
dependabot template-oss PR (@lukekarrys)
*
[`8fcd7ee`](8fcd7ee)
[#110](#110) bump
@npmcli/template-oss from 4.14.1 to 4.15.1 (@dependabot[bot])

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
const orderedMatches = []
for (const pattern of patterns) {
orderedMatches.push(...matches.filter((m) => {
return minimatch(m, pattern, { partial: true, windowsPathsNoEscape: true })
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not working correctly if workspaces contains leading ./ like: './packages/*'

@thecodrr
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants