Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't find executables in case-sensitive directory on Windows #57

Closed
Gudahtt opened this issue Aug 2, 2018 · 0 comments · Fixed by #100
Closed

Doesn't find executables in case-sensitive directory on Windows #57

Gudahtt opened this issue Aug 2, 2018 · 0 comments · Fixed by #100
Labels
Enhancement new feature or improvement

Comments

@Gudahtt
Copy link

Gudahtt commented Aug 2, 2018

Windows now features per-directory case-sensitivity. This is explained here: https://blogs.msdn.microsoft.com/commandline/2018/02/28/per-directory-case-sensitivity-and-wsl/
A directory created in the Windows Subsystem for Linux will be case-sensitive by default.

This library will read the PathExt environment variable to find file extensions, and try appending them to the input path one-by-one until it finds a match. The file extensions listed in PathExt are all upper-case.
As a result, the isexe check will always return false when the file extension of the executable file is lower-case.

Gudahtt added a commit to Gudahtt/node-which that referenced this issue Aug 2, 2018
Checks for both upper-case and lower-case file extensions. This is to
support case-sensitive directories on Windows.

Mixed-case file extensions still won't work, but those are rare enough
that I don't think it's worth the performance cost to check those as
well.

Closes npm#57
@lukekarrys lukekarrys added the Enhancement new feature or improvement label Oct 31, 2022
wraithgar added a commit that referenced this issue May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement new feature or improvement
Projects
None yet
2 participants