Add PATHEXT tests #58
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests `find when executable > with pathExt` were setting `process.env.PATHEXT`, as if to test to ensure that it would read from it correctly. But in both tests, the option `pathExt` was also set. This option is checked before `PATHEXT`, so `PATHEXT` was not tested. The `addTest` function has been given an additional optional parameter to specify a non-default set of options. New tests have been added to ensure `PATHEXT` is read correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests
find when executable > with pathExtwere settingprocess.env.PATHEXT, as if to test to ensure that it would read fromit correctly. But in both tests, the option
pathExtwas also set.This option is checked before
PATHEXT, soPATHEXTwas not tested.The
addTestfunction has been given an additional optional parameterto specify a non-default set of options. New tests have been added to
ensure
PATHEXTis read correctly.