Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: throw an err when alias is without name #184

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

milaninfy
Copy link
Contributor

throws error when alias spec is without name. e.g. ( foo@npm: )
Fixes: npm/cli#7590

@milaninfy milaninfy marked this pull request as ready for review July 19, 2024 21:50
@milaninfy milaninfy requested a review from a team as a code owner July 19, 2024 21:50
@wraithgar wraithgar changed the title fix: throws an err when alias is without name fix: throw an err when alias is without name Jul 22, 2024
@wraithgar wraithgar merged commit 59d53b3 into npm:main Jul 22, 2024
24 checks passed
@github-actions github-actions bot mentioned this pull request Jul 22, 2024
wraithgar pushed a commit that referenced this pull request Jul 22, 2024
🤖 I have created a release *beep* *boop*
---


##
[11.0.3](v11.0.2...v11.0.3)
(2024-07-22)

### Bug Fixes

*
[`59d53b3`](59d53b3)
[#184](#184) throws an err
when alias is without name (#184) (@milaninfy)

### Chores

*
[`911661e`](911661e)
[#176](#176) bump
@npmcli/template-oss to 4.22.0 (@lukekarrys)
*
[`575012e`](575012e)
[#186](#186) bump
@npmcli/template-oss from 4.22.0 to 4.23.1 (#186) (@dependabot[bot],
@wraithgar)
*
[`74d06ae`](74d06ae)
[#176](#176) postinstall for
dependabot template-oss PR (@lukekarrys)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@milaninfy milaninfy deleted the mm/fix-alias-without-name-err branch August 26, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Installing an aliased package with an empty name will install the 'undefined' package
2 participants