fix: properly parse non-url encoded file specs #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
There still appears to be some incorrect behavior here, that was here even before this PR. > require('.')('/path/br[acket')
Result {
type: 'directory',
registry: undefined,
where: '/Users/wraithgar/Development/npm/npm-package-arg/branches/gar_path-url-encoding',
raw: '/path/br[acket',
rawSpec: '/path/br[acket',
saveSpec: 'file:/path/br[acket',
fetchSpec: '/path/br[acket',
gitRange: undefined,
gitCommittish: undefined,
gitSubdir: undefined,
hosted: undefined
}
> decodeURI('file:/path/br[acket')
'file:/path/br[acket'but some new characters that this now allows (like %) will: I chose not to encode |
|
Still some |
wraithgar
force-pushed
the
gar/path-url-encoding
branch
5 times, most recently
from
3e28f1e to
ce6c05b
Compare
wraithgar
commented
Dec 20, 2024
|
|
||
| const normalizePath = p => p && p.replace(/^[a-zA-Z]:/, '').replace(/\\/g, '/') | ||
|
|
||
| const cwd = normalizePath(process.cwd()) | ||
| process.cwd = () => cwd | ||
| const normalizePaths = spec => { | ||
| spec.saveSpec = normalizePath(spec.saveSpec) |
There was a problem hiding this comment.
This was masking bugs.
Properly creates file package args that contain characters that need to be url encoded. There is also a refactor/cleanup in here - Removed the magic windows global for testing, fixing the tests to mock process.platform instead. - Moved inline regexes up to where the others are defined - Renamed a few variables to be more correct (i.e. isFilename to isFileType) - Refactored Result to be a proper Class instead of a function w/ prototypes Closes: #193
wraithgar
force-pushed
the
gar/path-url-encoding
branch
from
ce6c05b to
3c876a6
Compare
wraithgar
commented
Dec 20, 2024
| return isWindowsFile.test(spec) | ||
| } | ||
| // We never hit this in windows tests, obviously | ||
| /* istanbul ignore next */ |
There was a problem hiding this comment.
The fact that this was covered before is concerning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly creates file package args that contain characters that need to be url encoded.
There is also a refactor/cleanup in here
Closes: #193