fix: standardize x x@ and x@*
#97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
force-pushed
the
gar/normalize-defaults
branch
from
b0119a0 to
32a88d5
Compare
|
Will this have any implications on |
|
Nope, check out the rest of the comment.
|
lukekarrys
approved these changes
Sep 28, 2022
|
Converting to draft while I do the next phase, which is to |
wraithgar
force-pushed
the
gar/normalize-defaults
branch
from
32a88d5 to
f535d66
Compare
BREAKING CHANGE: `x` and `x@` now return the same spec as `x@*` From #45: Right now, `name@` and `name` are parsed with `{type:'tag', fetchSpec: 'latest'}`, but `name@*` is parsed as `{type: 'range'}`. But since `''` is a valid semver range, it should be parsed the same as `*`. This also saves npm-package-arg from guessing the default tag, which currently poses some semantic hazards. npm (via npm-pick-manifest) will prefer its default tag if given a range that includes it. But `name@latest` should always and only resolve to that specific version in the dist-tags. So npm-pick-manifest and pacote have to detect this and do some extra work to figure out if `latest` was actually specified or just guessed as a default. Closes npm/statusboard#460
wraithgar
force-pushed
the
gar/normalize-defaults
branch
from
f535d66 to
1bdb368
Compare
1 task
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
xandx@now return the same spec asx@*From #45:
Right now,
name@andnameare parsed with{type:'tag', fetchSpec: 'latest'}, butname@*is parsed as{type: 'range'}. But since''is a valid semver range, it should be parsed the same as*.This also saves npm-package-arg from guessing the default tag, which currently poses some semantic hazards. npm (via npm-pick-manifest) will prefer its default tag if given a range that includes it. But
name@latestshould always and only resolve to that specific version in the dist-tags. So npm-pick-manifest and pacote have to detect this and do some extra work to figure out iflatestwas actually specified or just guessed as a default.Closes npm/statusboard#460