nlf/workspace fixes #102
Merged
nlf/workspace fixes #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
approved these changes
May 19, 2022
1 task
3 tasks
nlf
added a commit
that referenced
this pull request
Aug 25, 2022
this backports the changes from #102
nlf
added a commit
that referenced
this pull request
Aug 25, 2022
this backports the changes from #102
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this one makes it so that when we're packing a workspace, we still respect .gitignore and .npmignore files that exist anywhere between the workspace root and the workspace itself, which is the behavior users would expect
currently packing a workspace root includes the workspaces themselves, this changes things so that workspaces are ignored by default when packing a root