Skip to content

Commit

Permalink
deps: @npmcli/run-script@6.0.0
Browse files Browse the repository at this point in the history
This also removes any setting of `stdioString` since `true` is the
default now.
  • Loading branch information
lukekarrys committed Nov 2, 2022
1 parent 62d9360 commit dbbda43
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 5 deletions.
1 change: 0 additions & 1 deletion lib/dir.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ class DirFetcher extends Fetcher {
pkg: mani,
event: 'prepare',
path: this.resolved,
stdioString: true,
stdio,
banner,
env: {
Expand Down
2 changes: 1 addition & 1 deletion lib/util/npm.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@ module.exports = (npmBin, npmCommand, cwd, env, extra) => {
// in temp directories. this lets us link previously-seen repos that
// are also being prepared.

return spawn(cmd, args, { cwd, stdioString: true, env }, extra)
return spawn(cmd, args, { cwd, env }, extra)
}
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"@npmcli/git": "^4.0.0",
"@npmcli/installed-package-contents": "^2.0.1",
"@npmcli/promise-spawn": "^6.0.1",
"@npmcli/run-script": "^5.0.0",
"@npmcli/run-script": "^6.0.0",
"cacache": "^17.0.0",
"fs-minipass": "^2.1.0",
"minipass": "^3.1.6",
Expand Down
4 changes: 2 additions & 2 deletions tap-snapshots/test/util/npm.js.test.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Object {
"message": "oopsie",
"signal": undefined,
"stderr": "",
"stdout": "[\\"{NODE}\\",[\\"/path/to/npm/bin/npm-cli.js\\",\\"flerb\\"],{\\"cwd\\":\\"/cwd\\",\\"stdioString\\":true,\\"env\\":{\\"environmental\\":\\"variables\\"}}]",
"stdout": "[\\"{NODE}\\",[\\"/path/to/npm/bin/npm-cli.js\\",\\"flerb\\"],{\\"cwd\\":\\"/cwd\\",\\"env\\":{\\"environmental\\":\\"variables\\"}}]",
}
`

Expand All @@ -30,6 +30,6 @@ Object {
"message": "oopsie",
"signal": undefined,
"stderr": "",
"stdout": "[\\"/path/to/npm\\",[\\"flerb\\"],{\\"cwd\\":\\"/cwd\\",\\"stdioString\\":true,\\"env\\":{\\"environmental\\":\\"variables\\"}}]",
"stdout": "[\\"/path/to/npm\\",[\\"flerb\\"],{\\"cwd\\":\\"/cwd\\",\\"env\\":{\\"environmental\\":\\"variables\\"}}]",
}
`

0 comments on commit dbbda43

Please sign in to comment.