Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: honors ignoreScripts option to prevent prepare lifecycle script #407

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

reggi
Copy link
Contributor

@reggi reggi commented Oct 15, 2024

Adds ignoreScript option support to prevent execution of prepare lifecycle script.

from: npm/cli#7211
part of: npm/statusboard#898

Currently the tests don't run locally for some reason, i'm thinking because they spin up a https://localhost server. It runs in docker.

I used this to isolate the build and test locally:

docker-node() { docker run --rm -v "$(pwd)":/app -w /app -e "TAP_SNAPSHOT=$TAP_SNAPSHOT" node:22 "$@"; }

docker-node npm test
docker-node npm test -- ./test/dir.js

@reggi reggi requested a review from a team as a code owner October 15, 2024 16:06
@reggi reggi force-pushed the reggi/ignore-scripts branch 2 times, most recently from d215fb9 to dc96529 Compare October 15, 2024 16:58
@reggi reggi changed the title feat: adds ignoreScripts to prevent prepare lifecycle fix!: honors ignoreScripts option to prevent prepare lifecycle script Oct 15, 2024
@reggi reggi changed the title fix!: honors ignoreScripts option to prevent prepare lifecycle script fix!: honors ignoreScripts option to prevent prepare lifecycle script Oct 15, 2024
…ript

BREAKING CHANGE: honors `ignoreScripts` property within options
@reggi reggi merged commit f27af63 into main Oct 17, 2024
17 checks passed
@reggi reggi deleted the reggi/ignore-scripts branch October 17, 2024 15:02
@github-actions github-actions bot mentioned this pull request Oct 17, 2024
reggi pushed a commit that referenced this pull request Oct 17, 2024
🤖 I have created a release *beep* *boop*
---


## [20.0.0](v19.0.1...v20.0.0)
(2024-10-17)
### ⚠️ BREAKING CHANGES
* honors `ignoreScripts` property within options
### Bug Fixes
*
[`f27af63`](f27af63)
[#407](#407) honors `ignoreScripts`
option to prevent `prepare` lifecycle script (@reggi)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants