Skip to content

Commit

Permalink
addendum: overrides apply if value matches, as well as key
Browse files Browse the repository at this point in the history
Found a pretty serious problem with overrides while starting
implementation.  Namely, it is in many cases impossible to determine
whether a node in a reified tree was subject to an override or not.

The edge case is described in this patch, and a fix proposed:

> **If a dependency matches the `key` in an overrides object _or_ it
> matches the `"."` value specifier, then the override ruleset will
> apply.**

By doing this, it prevents version-swapping, makes infinite regress even
more impossible, and ensures that the resulting package tree can always
be properly examined, without any out of band bookkeeping.

cc: @nlf
  • Loading branch information
isaacs committed Sep 2, 2021
1 parent efaeb0e commit c94c7f4
Showing 1 changed file with 194 additions and 90 deletions.
Loading

0 comments on commit c94c7f4

Please sign in to comment.