Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rfc: Hook script linking #48

Closed
wants to merge 1 commit into from

Conversation

lachlanhunt
Copy link

No description provided.

@isaacs
Copy link
Contributor

isaacs commented Aug 29, 2019

My main concern to investigate would be timing during installation.

Ie, if you npm install, and one of the packages being installed adds a preinstall hook, does it fire for the modules installed afterwards? If it adds a postinstall hook, does it fire for itself?

Even if we're ok with whatever the current default behavior would be, I'd like it documented so we don't break folks later by changing some undefined behavior.

@wesleytodd
Copy link

wesleytodd commented Nov 18, 2019

Since there can be only one file of each name (each of the predefined list of hook scripts), you would need some resolution logic to determine which to link wins or how to call them all (possibly changing the way that feature works today). Also, allowing any hook from any direct or transitive dep to be called for every installed dependency just by defining one in its package.json seems like an unintended (or at least unexpected) behavior.

Maybe I am not seeing the clear path forward for this RFC, but it seems like it is missing some large issues as it is defined today.

@darcyclarke
Copy link
Contributor

Closing this as hook scripts were removed in v7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement new feature or improvement Needs Discussion is pending a discussion Needs Documentation pull request requires docs before merging semver:minor new backwards-compatible feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants