Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tests): add test that checks lifecycle scripts don't run twice for linked deps #439

Closed
Tracked by #443
ruyadorno opened this issue Mar 10, 2022 · 0 comments · Fixed by npm/cli#4875
Closed
Tracked by #443

refactor(tests): add test that checks lifecycle scripts don't run twice for linked deps #439

ruyadorno opened this issue Mar 10, 2022 · 0 comments · Fixed by npm/cli#4875
Labels
chore refactor
Milestone
v9.0.0

Comments

@ruyadorno
Copy link

ruyadorno commented Mar 10, 2022 •
edited
Loading

Ref: npm/cli#2905
Ref: npm/cli#4529
@darcyclarke darcyclarke changed the title test: add test that checks lifecycle scripts don't runs twice for linked deps chore(test): add test that checks lifecycle scripts don't runs twice for linked deps Mar 23, 2022
@darcyclarke darcyclarke changed the title chore(test): add test that checks lifecycle scripts don't runs twice for linked deps refactor(tests): add test that checks lifecycle scripts don't run twice for linked deps Mar 23, 2022
@darcyclarke darcyclarke mentioned this issue Mar 23, 2022
Closed
32 tasks
ruyadorno added a commit to ruyadorno/cli that referenced this issue May 10, 2022
@ruyadorno
fix(arborist): link deps lifecycle scripts
0d95e7b 
- Fixes running proper lifecycle scripts for linked deps and
  workspaces.
- Added test to validate lifecycle scripts don't run twice
  for linked deps
- Tweaked "reify workspaces bin files" test to also validate
  proper lifecycle scripts ran before check for linked bins.
- Tweaked reify test running lifecycle scripts of unchanged link
  nodes to also validate that the install lifecycle scripts are
  also called.

Fixes: npm#4277
Fixes: npm#4552
Fixes: npm/statusboard#439
Relates to: npm#2905
ruyadorno added a commit to ruyadorno/cli that referenced this issue May 10, 2022
@ruyadorno
fix(arborist): link deps lifecycle scripts
0f8f932 
- Fixes running proper lifecycle scripts for linked deps and
  workspaces.
- Added test to validate lifecycle scripts don't run twice
  for linked deps
- Tweaked "reify workspaces bin files" test to also validate
  proper lifecycle scripts ran before check for linked bins.
- Tweaked reify test running lifecycle scripts of unchanged link
  nodes to also validate that the install lifecycle scripts are
  also called.

Fixes: npm#4277
Fixes: npm#4552
Fixes: npm/statusboard#439
Relates to: npm#2905
@ruyadorno ruyadorno mentioned this issue May 10, 2022
Merged
wraithgar pushed a commit to npm/cli that referenced this issue May 10, 2022
@ruyadorno
fix(arborist): link deps lifecycle scripts (#4875)
5a50762 
- Fixes running proper lifecycle scripts for linked deps and
  workspaces.
- Added test to validate lifecycle scripts don't run twice
  for linked deps
- Tweaked "reify workspaces bin files" test to also validate
  proper lifecycle scripts ran before check for linked bins.
- Tweaked reify test running lifecycle scripts of unchanged link
  nodes to also validate that the install lifecycle scripts are
  also called.

Fixes: #4277
Fixes: #4552
Fixes: npm/statusboard#439
Relates to: #2905
@lukekarrys lukekarrys added this to the v9.0.0 milestone Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore refactor
Projects
None yet
Milestone
v9.0.0
Development

Successfully merging a pull request may close this issue.

fix(arborist): link deps lifecycle scripts ruyadorno/cli
2 participants
@ruyadorno @lukekarrys