Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix make test-npm in node #45

Closed
ruyadorno opened this issue Jan 13, 2020 · 0 comments
Closed

Fix make test-npm in node #45

ruyadorno opened this issue Jan 13, 2020 · 0 comments
Assignees
@ruyadorno
Milestone
OSS - Sprint 2

Comments

@ruyadorno
Copy link

Running make test-npm in node is currently failing. From a quick glance I'm able to recognize that most of these errors are related to recent changes (such as adding snapshot tests but not the snapshots itself, etc).
@ruyadorno ruyadorno self-assigned this Jan 13, 2020
@ruyadorno ruyadorno added the Epic label Jan 13, 2020
@darcyclarke darcyclarke added this to the OSS - Sprint 2 milestone Jan 14, 2020
ruyadorno added a commit to ruyadorno/cli that referenced this issue Jan 16, 2020
@ruyadorno
chore: fixes nodejs tests
1d55ede 
- Fixes ability to run tests using an arbitrary node bin
- Fixes `make test-npm` in nodejs repo
  - Added `tap-snapshots` folder
  - Added required `.npmrc` root file

Fixes npm/statusboard#45
ruyadorno added a commit to ruyadorno/cli that referenced this issue Jan 16, 2020
@ruyadorno
chore: fixes nodejs tests
60db3b9 
- Fixes ability to run tests using an arbitrary node bin
- Fixes `make test-npm` in nodejs repo
  - Added `tap-snapshots` folder
  - Added required `.npmrc` root file

Fixes npm/statusboard#45
@ruyadorno ruyadorno mentioned this issue Jan 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruyadorno ruyadorno

Labels
None yet
Projects
None yet
Milestone
OSS - Sprint 2
Development

Successfully merging a pull request may close this issue.

chore: fixes nodejs tests ruyadorno/cli
2 participants
@ruyadorno @darcyclarke