feat: add issues permission to release workflow #276
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fritzy
force-pushed
the
fritzy/release-issues-perm
branch
from
4979f9a to
59305d5
Compare
|
Should probably be squashed. |
lukekarrys
reviewed
Feb 7, 2023
There was a problem hiding this comment.
After a bit more investigation, I'm not sure if the original failing workflow in npm/cli is a permissions issue.
All of our repos use the same action and I've seen some succeed and some fail with the latest version of template-oss:
stafftoolsfailed: https://github.com/npm/stafftools/actions/runs/4109009588/jobs/7090345220#step:8:121ignore-walksucceeded: chore: release 6.0.1 ignore-walk#70
I haven't root caused the issue but I did add some logging in #277 which should help the next time it fails.
|
The latest CLI release worked, so I'm chalking up the previous failure to "GitHub actions weirdness" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.