chore: extract common declarations #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jablko
commented
May 24, 2022
| @@ -11,6 +11,8 @@ export interface PackageJson { | |||
| * these help npm searches find your project | |||
| */ | |||
| keywords?: string[]; | |||
| homepage?: string; | |||
| bugs?: {url: string}; | |||
There was a problem hiding this comment.
homepage and bugs were only declared on the top-level of Packument before. Now they're declared on PackageJson and Packument uses Pick<PackumentVersion, "homepage" | "bugs">.
| @@ -23,6 +25,7 @@ export interface PackageJson { | |||
| peerDependencies?: Dependencies; | |||
| bundleDependencies?: Dependencies; | |||
| bundledDependencies?: Dependencies; | |||
| optionalDependencies?: ObjectOfStrings; | |||
There was a problem hiding this comment.
optionalDependencies was only declared on ManifestVersion before. Now it's declared on PackageJson and ManifestVersion uses Pick<PackumentVersion, "optionalDependencies">.
| maintainers: Maintainer[]; | ||
| dist: Dist; | ||
| readme?: string; | ||
| readmeFilename?: string; |
There was a problem hiding this comment.
readme and readmeFilename were only declared on the top-level of Packument before. Now they're declared on PackumentVersion and Packument uses Pick<PackumentVersion, "homepage" | "bugs">.
Closed
jablko
force-pushed
the
patch-2
branch
3 times, most recently
from
07daed0
to
be50483
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of repeating fields that are hoisted to the top-level of the packument from the latest version published, or repeating fields that are common to both full and abbreviated metadata, can we use
Pick<T, K>to list the hoisted/abbreviated fields?References
Depends on #15. I based this PR on #15 because this one depends on fixes from that one (e.g. the
licenseandenginesfields are optional).