Skip to content
This repository has been archived by the owner on Mar 26, 2021. It is now read-only.

Fixes for invalid GMT offset when creating new DateTimeZone in post-edit widget #53

Merged
merged 9 commits into from
Sep 19, 2018

Commits on May 23, 2018

  1. Move the DateTimeZone construction into its own separate testable fun…

    …ction, and write a test for that that iterates over the known valid GMT offsets from WordPress's database.
    
    This is for #52
    benlk committed May 23, 2018
    Configuration menu
    Copy the full SHA
    e87ccb2 View commit details
    Browse the repository at this point in the history
  2. remove extraneous error_log

    benlk committed May 23, 2018
    Configuration menu
    Copy the full SHA
    4b5a09c View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2018

  1. Fix minor typo

    benlk committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    07a4c23 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dfd8fbc View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2018

  1. Because Travis isn't initializing the plugin tests correctly, copy in…

    … the boilerplate from the 'wp scaffold plugin' command, without removing existing bootstrap.php functionality.
    benlk committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    7db701d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2c74c8b View commit details
    Browse the repository at this point in the history
  3. Pass $post to nprstory_publish_meta_box() in Test_MetaBoxes::test_npr…

    …story_publish_meta_box
    
    Fixes the error seen in https://travis-ci.com/npr/nprapi-wordpress/jobs/146555595
    
    1) Test_MetaBoxes::test_nprstory_publish_meta_box
    Missing argument 1 for nprstory_publish_meta_box(), called in /tmp/wordpress/src/wp-content/plugins/nprapi-wordpress/tests/test-meta-boxes.php on line 17 and defined
    /tmp/wordpress/src/wp-content/plugins/nprapi-wordpress/meta-boxes.php:18
    /tmp/wordpress/src/wp-content/plugins/nprapi-wordpress/tests/test-meta-boxes.php:17
    benlk committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    06db5b0 View commit details
    Browse the repository at this point in the history
  4. Fix 'undefined constant DateTimeZone' error in Test_PushStory::test_n…

    …prstory_get_datetimezone_all
    
    The error message:
    
    2) Test_PushStory::test_nprstory_get_datetimezone_all
    Use of undefined constant DateTimeZone - assumed 'DateTimeZone'
    /tmp/wordpress/src/wp-content/plugins/nprapi-wordpress/tests/test-push_story.php:163
    
    Must pass the class.
    benlk committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    08b4b5a View commit details
    Browse the repository at this point in the history
  5. clean up spacing in ds-npr-api.php

    this does not fix anything, but it does make the code in this file more readable, which helped with debugging the tests that were broken in #53 and that were fixed by commits 7db701d 2c74c8b
    benlk committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    1623aa0 View commit details
    Browse the repository at this point in the history