-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix egs_cbct, egs_fac compilation and egs_cbct example #940
Conversation
@rtownson thanks for looking into this! My only comment is that in the case of the non-zero rotation, if both, the blank scan and the actual scan use the same rotation, then there should be no issue as the projection would be place at the same location of their corresponding scan files! |
Setting the rotation to 0 will simply show a different phantom scan. So, it really doesn't matter. |
Actually, hold that thought! Something is not right! If I were to implement this now, I would just produce a blank scan whose size has to be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps add to the message reporting blank scan size mismatch a hint to set rotation to zero?
I will merge this into |
Added the egs_fac fixes, now ready to merge. |
Fix a compiler error that occurred with newer compiler settings due to ambiguous declaration of isinf and isnan. Also change the z-rotation parameter in the example input file to be 0 so that it calculates the first projection instead of a later projection. This avoids a common user error when trying to produce the blank scan for the first time.
42b5f1b
to
eda9bb2
Compare
Squashed the 3 commits. |
Fix a compiler error that occurred with newer compiler settings due to ambiguous declaration of isinf and isnan, by adding
std::
.Also change the z-rotation parameter in the example input file to be 0 so that it calculates the first projection instead of a later projection. This avoids a common user error when trying to produce the blank scan for the first time, as reported here: https://www.reddit.com/r/EGSnrc/comments/z36841/query_fatal_error_message_egs_cbct_blank_scan/