Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial commit of Jax integration [WIP] #23

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

iancharest
Copy link

@iancharest iancharest commented Feb 4, 2021

Jax seems to offer quite substantial speed improvements on things like svd compared to numpy and scipy, even in the absence of GPU or TPU.

Let's see if this is the case. we will add jax to fracridge, and then test it with glm_denoisesingletrial

  • add jax to requirements.
  • try and catch jax, else use scipy

@iancharest
Copy link
Author

ok, learning a bit about jax.
https://github.com/iancharest/fracridge/blob/46c3090ef47c241dc07a399f60d28dbb7ea9e0bf/fracridge/fracridge.py#L155
leads to:
TypeError: '<class 'jax.interpreters.xla.DeviceArray'>' object does not support item assignment. JAX arrays are immutable; perhaps you want jax.ops.index_update or jax.ops.index_add instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant