Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samples: openthread: Enable USB CDC ACM for Spinel #4121

Merged
merged 3 commits into from
Jul 1, 2021
Merged

samples: openthread: Enable USB CDC ACM for Spinel #4121

merged 3 commits into from
Jul 1, 2021

Conversation

lmaciejonczyk
Copy link
Contributor

It enables emulation serial port over USB in Co-processor sample.
The communication host - co-processor is done through USB.

@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label Mar 9, 2021
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@lmaciejonczyk lmaciejonczyk force-pushed the ot/usb_2 branch 2 times, most recently from 65471b2 to 6617a02 Compare March 24, 2021 14:17
@github-actions
Copy link

github-actions bot commented Mar 24, 2021 •
edited
Loading

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
zephyr nrfconnect/sdk-zephyr@v2.6.0-ncs1-rc3 nrfconnect/sdk-zephyr@a2d2a5e nrfconnect/sdk-zephyr@v2.6.0-ncs1-rc3..a2d2a5e1

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@github-actions github-actions bot added the CI-all-test Run All integration tests label Apr 7, 2021
@lmaciejonczyk lmaciejonczyk force-pushed the ot/usb_2 branch 3 times, most recently from b52263b to 13459c4 Compare April 23, 2021 12:00
@github-actions
Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Jun 23, 2021
@github-actions github-actions bot removed manifest CI-all-test Run All integration tests labels Jun 23, 2021
@lmaciejonczyk lmaciejonczyk force-pushed the ot/usb_2 branch 7 times, most recently from acaccfd to 248c27f Compare June 29, 2021 08:25
@lmaciejonczyk lmaciejonczyk requested review from ru-fu and edmont June 29, 2021 08:28
@lmaciejonczyk lmaciejonczyk marked this pull request as ready for review June 29, 2021 08:28
@lmaciejonczyk
Copy link
Contributor Author

@ru-fu Feel free to modify docs changes if needed, thanks.

@lmaciejonczyk
samples: openthread: prefer deferred logging for all samples
5bde0ce 
Use LOG_MODE_DEFERRED to decrease logging impact on the application.

Signed-off-by: Lukasz Maciejonczyk <lukasz.maciejonczyk@nordicsemi.no>
@lmaciejonczyk lmaciejonczyk mentioned this pull request Jun 29, 2021
Closed
ru-fu
ru-fu suggested changes Jun 30, 2021
View reviewed changes
doc/nrf/ug_thread_tools.rst Outdated Show resolved Hide resolved
doc/nrf/ug_thread_tools.rst Show resolved Hide resolved
doc/nrf/ug_thread_tools.rst Show resolved Hide resolved
@lmaciejonczyk lmaciejonczyk mentioned this pull request Jul 1, 2021
Merged
1 task
ru-fu
ru-fu reviewed Jul 1, 2021
View reviewed changes
Copy link

@ru-fu ru-fu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a commit - please check and squash, if okay.

@lmaciejonczyk lmaciejonczyk force-pushed the ot/usb_2 branch 2 times, most recently from 7c294f2 to 31c0fa6 Compare July 1, 2021 09:58
@lmaciejonczyk
Copy link
Contributor Author

I added a commit - please check and squash, if okay.

LGTM, thanks!

ru-fu
ru-fu reviewed Jul 1, 2021
View reviewed changes
Copy link

@ru-fu ru-fu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed one file.

samples/openthread/coprocessor/README.rst Outdated Show resolved Hide resolved
@lmaciejonczyk
samples: openthread: enable USB CDC ACM for NCP/RCP
b9b5086 
It enables emulation serial port over USB in Co-Processor sample
for Spinel communication with the host.

Signed-off-by: Lukasz Maciejonczyk <lukasz.maciejonczyk@nordicsemi.no>
@lmaciejonczyk
samples: openthread: add missing twister tests for CLI sample
59b712f 
Build variants: minimal_multiprotocol and minimal_singleprotocol haven't
been checked. This commit fixes it.

Signed-off-by: Lukasz Maciejonczyk <lukasz.maciejonczyk@nordicsemi.no>
@rlubos rlubos merged commit 034142e into nrfconnect:master Jul 1, 2021
@rlubos rlubos deleted the ot/usb_2 branch July 1, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlubos rlubos rlubos approved these changes

@ru-fu ru-fu ru-fu approved these changes

@edmont edmont edmont approved these changes

@carlescufi carlescufi Awaiting requested review from carlescufi

@MarekPorwisz MarekPorwisz Awaiting requested review from MarekPorwisz

Assignees
No one assigned
Labels
doc-required PR must not be merged without tech writer approval. manifest-zephyr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lmaciejonczyk @NordicBuilder @edmont @ru-fu @rlubos