-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nrf_cloud: unittest: editted cloud unit tests to be run automatically #9872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tony-le-24
requested review from
plskeggs,
jayteemo,
balaji-srin and
glarsennordic
January 10, 2023 21:52
github-actions
bot
added
the
changelog-entry-required
Update changelog before merge. Remove label if entry is not needed or already added.
label
Jan 10, 2023
tony-le-24
removed
the
changelog-entry-required
Update changelog before merge. Remove label if entry is not needed or already added.
label
Jan 10, 2023
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
need inquiries from @balaji-nordic to fix twister check. |
balaji-srin
previously requested changes
Jan 11, 2023
jayteemo
approved these changes
Jan 11, 2023
github-actions
bot
added
the
changelog-entry-required
Update changelog before merge. Remove label if entry is not needed or already added.
label
Jan 11, 2023
tony-le-24
removed
the
changelog-entry-required
Update changelog before merge. Remove label if entry is not needed or already added.
label
Jan 11, 2023
plskeggs
approved these changes
Jan 12, 2023
balaji-srin
approved these changes
Jan 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested a small update to the wording. Looks good otherwise.
Added integration platforms of qemu_cortex_m3 and native_posix, also added Kconfigs overlay for qemu_cortex_m3. These will make the unit tests run automatically with sdk-nrf integration. See IRIS-4986 Signed-off-by: Tony Le <tony.le@nordicsemi.no>
github-actions
bot
added
the
changelog-entry-required
Update changelog before merge. Remove label if entry is not needed or already added.
label
Jan 12, 2023
tony-le-24
removed
the
changelog-entry-required
Update changelog before merge. Remove label if entry is not needed or already added.
label
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added integration platforms of qemu_cortex_m3 and native_posix, also added Kconfigs overlay for qemu_cortex_m3. These will make the unit tests run automatically with sdk-nrf integration.
See IRIS-4986
Signed-off-by: Tony Le tony.le@nordicsemi.no