Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support yarn berry #43

Merged
merged 7 commits into from
Nov 14, 2022
Merged

feat: support yarn berry #43

merged 7 commits into from
Nov 14, 2022

Conversation

Michsior14
Copy link
Contributor

Super simple implementation for yarn berry. Feel free to take parts that you are happy with :)

Resolves #24.

Copy link
Collaborator

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this @Michsior14 - please also add an integration test workflow which leverages this. There is plenty of prior art for you to take inspiration from

.github/workflows/nx-cloud-agents.yml Outdated Show resolved Hide resolved
@Michsior14
Copy link
Contributor Author

Thanks a lot for this @Michsior14 - please also add an integration test workflow which leverages this. There is plenty of prior art for you to take inspiration from

Will do it after work hours ;)

@Michsior14
Copy link
Contributor Author

@JamesHenry Integration tests added.

@JamesHenry
Copy link
Collaborator

Looks like it's working well:

image

image

I ran it a second time to make sure there would be a cache hit and there was:

image

image

@JamesHenry
Copy link
Collaborator

JamesHenry commented Nov 10, 2022

@Michsior14 thanks a lot for this, please bump the minor version in the root package.json to 0.10.0 so that an appropriate release will be triggered post-merge

@JamesHenry JamesHenry requested a review from meeroslav November 10, 2022 18:34
Copy link
Collaborator

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

I requested review from @meeroslav on this one as well as I still very jet lagged and I might have missed something 😄

@Michsior14
Copy link
Contributor Author

Hey @meeroslav! Any update on the review? :)

Copy link
Collaborator

@meeroslav meeroslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you

I left one minor comment, but it's not a blocker

@JamesHenry JamesHenry enabled auto-merge (squash) November 14, 2022 12:04
@JamesHenry JamesHenry merged commit a27717a into nrwl:main Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support yarn v2+
3 participants