Skip to content

Commit

Permalink
fix(js): respect "watch" option when "runBuildTargetDependencies" is …
Browse files Browse the repository at this point in the history
…true (#27677)

This PR fixes and issue when `watch: false` and
`runBuildTargetDependencies: true` results in the server process
restarting, but no build happens.

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #20963

(cherry picked from commit d1c901d)
  • Loading branch information
jaysoo authored and FrozenPandaz committed Aug 28, 2024
1 parent 9dcc458 commit 5f34910
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions packages/js/src/executors/node/node.impl.ts
Original file line number Diff line number Diff line change
Expand Up @@ -276,8 +276,10 @@ export async function* nodeExecutor(
} else if (err) {
logger.error(`Watch error: ${err?.message ?? 'Unknown'}`);
} else {
logger.info(`NX File change detected. Restarting...`);
await runBuild();
if (options.watch) {
logger.info(`NX File change detected. Restarting...`);
await runBuild();
}
}
}
);
Expand Down

0 comments on commit 5f34910

Please sign in to comment.