Merge branch 'master' into feat/add-vitest-option-to-angular

.circleci/config.yml

@@ -87,11 +87,12 @@ jobs:
       NX_CI_EXECUTION_ENV: 'linux'
       NX_CLOUD_DTE_V2: 'true'
       NX_CLOUD_DTE_SUMMARY: 'true'
+      NX_CLOUD_NO_TIMEOUTS: 'true'
     steps:
       - checkout
       - nx/set-shas:
           main-branch-name: 'master'
-      - run: npx nx-cloud@next start-ci-run --distribute-on="auto linux-medium" --stop-agents-after="e2e"
+      - run: npx nx-cloud@next start-ci-run --distribute-on="auto linux-medium" --stop-agents-after="e2e" --require-explicit-completion
       - run:
           command: |
             sudo apt-get update
@@ -121,6 +122,10 @@ jobs:
             for pid in "${pids[@]}"; do
               wait "$pid"
             done
+      - run:
+          name: End CI Run
+          command: npx nx-cloud@next complete-ci-run
+          no_output_timeout: 20m
   # -------------------------
   #     JOBS: Main-MacOS
   # -------------------------

.eslintrc.json

@@ -64,6 +64,16 @@
         ],
         "@nx/workspace/valid-command-object": "error"
       }
+    },
+    {
+      "files": ["pnpm-lock.yaml"],
+      "parser": "./tools/eslint-rules/raw-file-parser.js",
+      "rules": {
+        "@nx/workspace/ensure-pnpm-lock-version": [
+          "error",
+          { "version": "9.0" }
+        ]
+      }
     }
   ]
 }

.github/ISSUE_TEMPLATE/1-bug.yml

@@ -1,6 +1,7 @@
 name: 🐞 Bug Report
 description: This form is to report unexpected behavior in Nx.
 labels: ["type: bug"]
+type: Bug
 body:
   - type: markdown
     attributes:

.github/workflows/npm-audit.yml

@@ -8,25 +8,21 @@ on:
 permissions: {}
 jobs:
   audit:
+    if: ${{ github.repository_owner == 'nrwl' }}
     permissions:
       contents: read  #  to fetch code (actions/checkout)
-
     runs-on: ubuntu-latest
-
     steps:
       - name: Checkout
         uses: actions/checkout@v3
 
-      - name: Install PNPM
-        run: |
-          npm install -g @pnpm/exe@8
+      - uses: pnpm/action-setup@v4
+        with:
+          version: 9.8.0 # Aligned with root package.json (pnpm/action-setup will helpfully error if out of sync)
 
       - name: Run a security audit
         run: pnpm dlx audit-ci --critical --report-type summary
 
-    # - name: Run Dependency confusion supply chain check
-    #  run: npx snync -d .
-
   report:
     if: ${{ always() && github.repository_owner == 'nrwl' && github.event_name != 'workflow_dispatch' }}
     needs: audit

.husky/post-checkout

@@ -1,3 +1,2 @@
-#!/bin/sh
 changedFiles="$(git diff-tree -r --name-only --no-commit-id $1 $2)"
-node ./scripts/notify-lockfile-changes.js $changedFiles
+node ./scripts/notify-lockfile-changes.js $changedFiles

.husky/post-merge

@@ -1,3 +1,2 @@
-#!/bin/sh
 changedFiles="$(git diff-tree -r --name-only --no-commit-id ORIG_HEAD HEAD)"
-node ./scripts/notify-lockfile-changes.js $changedFiles
+node ./scripts/notify-lockfile-changes.js $changedFiles

.husky/pre-push

@@ -1,6 +1,4 @@
-#!/usr/bin/env sh
-
-pnpm check-lock-files &&
-pnpm check-commit &&
-pnpm documentation &&
+pnpm check-lock-files
+pnpm check-commit
+pnpm documentation
 pnpm pretty-quick --check

.local.env

@@ -1 +0,0 @@
-NX_DB_CACHE=true

CODEOWNERS

@@ -10,7 +10,7 @@ rust-toolchain @nrwl/nx-native-reviewers
 
 # Docs Site + Graph
 /docs @nrwl/nx-docs-reviewers
-/docs/nx-cloud @StalkAltan @rarmatei @nrwl/nx-docs-reviewers
+/docs/nx-cloud @StalkAltan @rarmatei @nixallover @nrwl/nx-docs-reviewers
 /graph/** @philipjfulcher @FrozenPandaz @bcabanes @MaxKless @xiongemi
 /images @nrwl/nx-docs-reviewers
 /nx-dev/** @nrwl/nx-docs-reviewers
@@ -79,12 +79,14 @@ rust-toolchain @nrwl/nx-native-reviewers
 /docs/generated/packages/js/** @nrwl/nx-js-reviewers @nrwl/nx-docs-reviewers
 /docs/generated/packages/web/** @nrwl/nx-js-reviewers @nrwl/nx-docs-reviewers
 /docs/generated/packages/webpack/** @nrwl/nx-js-reviewers @nrwl/nx-docs-reviewers
+/docs/generated/packages/rspack/** @nrwl/nx-js-reviewers @nrwl/nx-docs-reviewers
 /docs/generated/packages/esbuild/** @nrwl/nx-js-reviewers @nrwl/nx-docs-reviewers
 /docs/generated/packages/rollup/** @nrwl/nx-js-reviewers @nrwl/nx-docs-reviewers
 /docs/generated/packages/vite/** @nrwl/nx-js-reviewers @nrwl/nx-docs-reviewers
 /docs/shared/packages/js/** @nrwl/nx-js-reviewers @nrwl/nx-docs-reviewers
 /docs/shared/packages/web/** @nrwl/nx-js-reviewers @nrwl/nx-docs-reviewers
 /docs/shared/packages/webpack/** @nrwl/nx-js-reviewers @nrwl/nx-docs-reviewers
+/docs/shared/packages/rspack/** @nrwl/nx-js-reviewers @nrwl/nx-docs-reviewers
 /docs/shared/packages/esbuild/** @nrwl/nx-js-reviewers @nrwl/nx-docs-reviewers
 /docs/shared/packages/vite/** @nrwl/nx-js-reviewers @nrwl/nx-docs-reviewers
 /packages/js/** @nrwl/nx-js-reviewers
@@ -94,6 +96,9 @@ rust-toolchain @nrwl/nx-native-reviewers
 /packages/webpack/** @nrwl/nx-js-reviewers
 /packages/webpack/src/utils/module-federation @jaysoo @Coly010
 /e2e/webpack/** @nrwl/nx-js-reviewers
+/packages/rspack/** @nrwl/nx-js-reviewers
+/packages/rspack/src/utils/module-federation @jaysoo @Coly010
+/e2e/rspack/** @nrwl/nx-js-reviewers
 /packages/esbuild/** @nrwl/nx-js-reviewers
 /e2e/esbuild/** @nrwl/nx-js-reviewers
 /packages/rollup/** @nrwl/nx-js-reviewers

CONTRIBUTING.md

@@ -363,7 +363,7 @@ Including the issue number that the PR relates to also helps with tracking.
 ```plain
 feat(angular): add an option to generate lazy-loadable modules
 
-`nx generate lib mylib --lazy` provisions the mylib project in .eslintrc.json
+`nx generate lib libs/mylib --lazy` provisions the mylib project in .eslintrc.json
 
 Closes #157
 ```