fix(rspack): stick to commonjs

nrwl · Nov 12, 2024 · 926c6ba · 926c6ba
1 parent 4d95a74
commit 926c6ba
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/packages/rspack/.eslintrc.json b/packages/rspack/.eslintrc.json
@@ -40,7 +40,9 @@
               // Imported types only
               "@module-federation/sdk",
               "@module-federation/enhanced",
-              "css-loader"
+              "css-loader",
+              // required by webpack-subresource-integrity
+              "webpack"
             ]
           }
         ]

diff --git a/packages/rspack/package.json b/packages/rspack/package.json
@@ -31,6 +31,7 @@
     "@rspack/core": "^1.0.4",
     "@rspack/dev-server": "^1.0.4",
     "@rspack/plugin-react-refresh": "^1.0.0",
+    "webpack": "^5.80.0",
     "autoprefixer": "^10.4.9",
     "browserslist": "^4.21.4",
     "chalk": "~4.1.0",

diff --git a/packages/rspack/src/plugins/utils/apply-base-config.ts b/packages/rspack/src/plugins/utils/apply-base-config.ts
@@ -117,10 +117,6 @@ function applyNxIndependentConfig(
     hashFunction: config.output?.hashFunction ?? 'xxhash64',
     // Disabled for performance
     pathinfo: config.output?.pathinfo ?? false,
-    // Use CJS for Node since it has the widest support.
-    scriptType:
-      config.output?.scriptType ??
-      (options.target === 'node' ? undefined : 'module'),
   };
 
   config.watch = options.watch;