Skip to content

Commit

Permalink
chore(bundling): rename env vars so we do not cause Nx Cloud connecti…
Browse files Browse the repository at this point in the history
…on errors (#27681)

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
  • Loading branch information
jaysoo authored Aug 28, 2024
1 parent be37c35 commit adcefcc
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions e2e/esbuild/src/esbuild.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -241,16 +241,16 @@ describe('EsBuild Plugin', () => {
updateFile(
`libs/${myPkg}/src/index.ts`,
`
console.log(process.env['NX_CLOUD_ENCRYPTION_KEY']);
console.log(process.env['NX_CLOUD_ACCESS_TOKEN']);
console.log(process.env['NX_SOME_SECRET']);
console.log(process.env['NX_SOME_TOKEN']);
console.log(process.env['NX_PUBLIC_TEST']);
`
);

runCLI(`build ${myPkg} --platform=browser`, {
env: {
NX_CLOUD_ENCRYPTION_KEY: 'secret',
NX_CLOUD_ACCESS_TOKEN: 'secret',
NX_SOME_SECRET: 'secret',
NX_SOME_TOKEN: 'secret',
NX_PUBLIC_TEST: 'foobar',
},
});
Expand Down

0 comments on commit adcefcc

Please sign in to comment.