Skip to content

Commit

Permalink
fix(angular): when unit test runner is set to none library component …
Browse files Browse the repository at this point in the history
…should not generate spec file (#28906)

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->
When unitTestRunner is set to none, spec files are still generated


## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
SkipTests when unit test runner set to none

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
  • Loading branch information
Coly010 authored Nov 12, 2024
1 parent a3dbc40 commit cd121bd
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ export async function normalizeOptions(
fileName,
importPath,
ngCliSchematicLibRoot,
skipTests: options.unitTestRunner === 'none' ? true : options.skipTests,
standaloneComponentName: `${
names(projectNames.projectSimpleName).className
}Component`,
Expand Down

0 comments on commit cd121bd

Please sign in to comment.