Skip to content

Commit

Permalink
fix(angular): @angular/core should always be provided as a shared pac…
Browse files Browse the repository at this point in the history
…kage #19121 (#23464)

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->
In our Module Federation utils for Angular, we set some packages that
should always be shared.
This array was missing `@angular/core` which should be shared at all
times for DI to function as expected

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->
Ensure `@angular/core` is shared

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #19121

(cherry picked from commit 4315e91)
  • Loading branch information
Coly010 authored and FrozenPandaz committed May 21, 2024
1 parent 2116acb commit e4d1f52
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions packages/angular/src/utils/mf/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ export const DEFAULT_NPM_PACKAGES_TO_AVOID = [
'@nrwl/angular/mf',
];
export const DEFAULT_ANGULAR_PACKAGES_TO_SHARE = [
'@angular/core',
'@angular/animations',
'@angular/common',
];
Expand Down

0 comments on commit e4d1f52

Please sign in to comment.