fix(core): projects should work with nodenext set in tsconfig

nrwl · Nov 6, 2024 · e7d7590 · e7d7590
1 parent b14d5c5
commit e7d7590
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 0 deletions.
diff --git a/packages/jest/src/plugins/__snapshots__/plugin.spec.ts.snap b/packages/jest/src/plugins/__snapshots__/plugin.spec.ts.snap
@@ -39,6 +39,9 @@ exports[`@nx/jest/plugin should add package as externalDependencies to the input
               },
               "options": {
                 "cwd": "proj",
+                "env": {
+                  "TS_NODE_COMPILER_OPTIONS": "{"moduleResolution":"node10"}",
+                },
               },
               "outputs": [
                 "{workspaceRoot}/coverage",
@@ -91,6 +94,9 @@ exports[`@nx/jest/plugin should add package as externalDependencies to the input
               },
               "options": {
                 "cwd": "proj",
+                "env": {
+                  "TS_NODE_COMPILER_OPTIONS": "{"moduleResolution":"node10"}",
+                },
               },
               "outputs": [
                 "{workspaceRoot}/coverage",
@@ -143,6 +149,9 @@ exports[`@nx/jest/plugin should add package as externalDependencies to the input
               },
               "options": {
                 "cwd": "proj",
+                "env": {
+                  "TS_NODE_COMPILER_OPTIONS": "{"moduleResolution":"node10"}",
+                },
               },
               "outputs": [
                 "{workspaceRoot}/coverage",

diff --git a/packages/jest/src/plugins/plugin.spec.ts b/packages/jest/src/plugins/plugin.spec.ts
@@ -96,6 +96,9 @@ describe('@nx/jest/plugin', () => {
                     },
                     "options": {
                       "cwd": "proj",
+                      "env": {
+                        "TS_NODE_COMPILER_OPTIONS": "{"moduleResolution":"node10"}",
+                      },
                     },
                     "outputs": [
                       "{workspaceRoot}/coverage",
@@ -173,6 +176,9 @@ describe('@nx/jest/plugin', () => {
                     },
                     "options": {
                       "cwd": "proj",
+                      "env": {
+                        "TS_NODE_COMPILER_OPTIONS": "{"moduleResolution":"node10"}",
+                      },
                     },
                     "outputs": [
                       "{workspaceRoot}/coverage",
@@ -306,6 +312,9 @@ describe('@nx/jest/plugin', () => {
                     },
                     "options": {
                       "cwd": "proj",
+                      "env": {
+                        "TS_NODE_COMPILER_OPTIONS": "{"moduleResolution":"node10"}",
+                      },
                     },
                     "outputs": [
                       "{workspaceRoot}/coverage",
@@ -413,6 +422,9 @@ describe('@nx/jest/plugin', () => {
                     },
                     "options": {
                       "cwd": "proj",
+                      "env": {
+                        "TS_NODE_COMPILER_OPTIONS": "{"moduleResolution":"node10"}",
+                      },
                     },
                     "outputs": [
                       "{workspaceRoot}/coverage",
@@ -480,6 +492,9 @@ describe('@nx/jest/plugin', () => {
                     },
                     "options": {
                       "cwd": "proj",
+                      "env": {
+                        "TS_NODE_COMPILER_OPTIONS": "{"moduleResolution":"node10"}",
+                      },
                     },
                     "outputs": [
                       "{workspaceRoot}/coverage",
@@ -593,6 +608,9 @@ describe('@nx/jest/plugin', () => {
                     },
                     "options": {
                       "cwd": "proj",
+                      "env": {
+                        "TS_NODE_COMPILER_OPTIONS": "{"moduleResolution":"node10"}",
+                      },
                     },
                     "outputs": [
                       "{workspaceRoot}/coverage",
@@ -660,6 +678,9 @@ describe('@nx/jest/plugin', () => {
                     },
                     "options": {
                       "cwd": "proj",
+                      "env": {
+                        "TS_NODE_COMPILER_OPTIONS": "{"moduleResolution":"node10"}",
+                      },
                     },
                     "outputs": [
                       "{workspaceRoot}/coverage",

diff --git a/packages/jest/src/plugins/plugin.ts b/packages/jest/src/plugins/plugin.ts
@@ -192,6 +192,9 @@ async function buildJestTargets(
     command: 'jest',
     options: {
       cwd: projectRoot,
+      // Jest registers ts-node with module CJS https://github.com/SimenB/jest/blob/v29.6.4/packages/jest-config/src/readConfigFileAndSetRootDir.ts#L117-L119
+      // Since we are moving in the direction of ESM via `module` nodenext, we need to override the resolution until Jest supports it.
+      env: { TS_NODE_COMPILER_OPTIONS: '{"moduleResolution":"node10"}' },
     },
     metadata: {
       technologies: ['jest'],
@@ -269,6 +272,7 @@ async function buildJestTargets(
           outputs,
           options: {
             cwd: projectRoot,
+            env: { TS_NODE_COMPILER_OPTIONS: '{"moduleResolution":"node10"}' },
           },
           metadata: {
             technologies: ['jest'],