Skip to content

Commit

Permalink
cleanup(core): fix grammar issues and remove outdated comment
Browse files Browse the repository at this point in the history
  • Loading branch information
leosvelperez committed Sep 10, 2024
1 parent 29763a2 commit f6c6e6d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
4 changes: 1 addition & 3 deletions packages/nx/src/command-line/sync/sync.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,6 @@ export function syncHandler(options: SyncOptions): Promise<number> {
getFailedSyncGeneratorsFixMessageLines(results, options.verbose);

if (areAllResultsFailures) {
// if all sync generators failed to run we can't say for sure if the workspace is out of sync
// because they could have failed due to a bug, so we print a warning and exit with code 0
output.error({
title: `The workspace is probably out of sync because ${
failedGeneratorsCount === 1
Expand Down Expand Up @@ -128,7 +126,7 @@ export function syncHandler(options: SyncOptions): Promise<number> {
e.message,
...(options.verbose && !!e.stack ? [`\n${e.stack}`] : []),
'',
'Please make sure to run with `--verbose` and report the error at: https://github.com/nrwl/nx/issues/new/choose',
'Please rerun with `--verbose` and report the error at: https://github.com/nrwl/nx/issues/new/choose',
],
});

Expand Down
8 changes: 4 additions & 4 deletions packages/nx/src/tasks-runner/run-command.ts
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ async function ensureWorkspaceIsInSyncAndGetGraphs(
const fixMessage =
'You can manually run `nx sync` to update your workspace with the identified changes or you can set `sync.applyChanges` to `true` in your `nx.json` to apply the changes automatically when running tasks in interactive environments.';
const willErrorOnCiMessage =
'Please note that having the workspace out of sync will result in an error on CI.';
'Please note that having the workspace out of sync will result in an error in CI.';

if (isCI() || !process.stdout.isTTY) {
// If the user is running in CI or is running in a non-TTY environment we
Expand Down Expand Up @@ -410,8 +410,8 @@ async function ensureWorkspaceIsInSyncAndGetGraphs(
'The workspace was synced successfully!';
const successSubtitle =
nxJson.sync?.applyChanges === true
? 'Please make sure to commit the changes to your repository or this will error on CI.'
: // The user was prompted and we already logged a message about erroring on CI
? 'Please make sure to commit the changes to your repository or this will error in CI.'
: // The user was prompted and we already logged a message about erroring in CI
// so here we just tell them to commit the changes.
'Please make sure to commit the changes to your repository.';
spinner.succeed(`${successTitle}\n\n${successSubtitle}`);
Expand Down Expand Up @@ -503,7 +503,7 @@ async function confirmRunningTasksWithSyncFailures(): Promise<void> {
],
footer: () =>
chalk.dim(
`\nWhen running on CI and there are sync failures, the tasks won't run. Addressing the errors above is highly recommended to prevent failures in CI.`
`\nWhen running in CI and there are sync failures, the tasks won't run. Addressing the errors above is highly recommended to prevent failures in CI.`
),
};

Expand Down

0 comments on commit f6c6e6d

Please sign in to comment.