Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing CSS import in Web Component app #1249

Closed
luchsamapparat opened this issue Apr 11, 2019 · 3 comments · Fixed by #1260
Closed

Missing CSS import in Web Component app #1249

luchsamapparat opened this issue Apr 11, 2019 · 3 comments · Fixed by #1260
Assignees

Comments

@luchsamapparat
Copy link
Contributor

Expected Behavior

When creating a new a web component application, a custom element named AppElement is automatically generated. Alongside the ts file, there's also a .css file (or whatever style you chose), however, that file is not imported by the ts file and therefore not part of the build. I'd expect that there's an import on that file.

Current Behavior

The file is not imported anywhere.

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. create-nx-workspace web-component-poc
  2. choose web component

Context

Please provide any relevant information about your setup:

  • version of Nx used: 7.8.9
  • version of Angular CLI used 7.3.1
  • angular.json configuration as generated
  • version of Angular DevKit used 7.3.1

Other

import './app.element.css'; // 👈 that's missing

export class AppElement extends HTMLElement {
  public static observedAttributes = [];
...
@luchsamapparat
Copy link
Contributor Author

In case this is indeed a bug and not intended behavior, I could provide a PR

@vsavkin
Copy link
Member

vsavkin commented Apr 14, 2019

@luchsamapparat
This is a bug. It'd be awesome if you could send a PR fixing it.

@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants