affected:build --all does not consider dependency graph / implicitDependencies

[dherges]

Prerequisites

Please answer the following questions for yourself before submitting an issue.
YOU MAY DELETE THE PREREQUISITES SECTION.

• I am running the latest version
• I checked the documentation and found no answer
• I checked to make sure that this issue has not already been filed
• I'm reporting the issue to the correct repository (not related to Angular, AngularCLI or any dependency)

Expected Behavior

Reproduction repo: https://github.com/dherges/nx-affects-build-implicit-deps

{
  "projects": {
    "foobar": {
      "tags": [],
      "implicitDependencies": ["shared"]
    },
    "shared": {
      "tags": []
    }
  }
}

$ ./node_modules/.bin/nx affected:build --all
Running build for projects:
  foobar,
  shared
Running build for shared
Running build for foobar
Running build for affected projects succeeded.

Current Behavior

$ ./node_modules/.bin/nx affected:build --all
Running build for projects:
  foobar,
  shared
Running build for foobar
Running build for shared
Running build for affected projects succeeded.

Failure Information (for bugs)

The dependency graph should be considered to determine the order which project needs to be built prior to satisfy dependencies of another project.

Steps to Reproduce

Reproduction repo: https://github.com/dherges/nx-affects-build-implicit-deps

Edit nx.json to add implicit dependencies

Context

The order of implicit dependencies becomes an issue when static resources are generated from a library project. Generated resources should then be consumed by an app, e.g. added to the assets configuration in nagular.json.

One real-world example is:

• generate an icon font from set of svg files
• icon font is added as library project to nx workspace, w/ run command builder
• app project should be able to consume generated icon font files, add implicit dependencies to library project
• if projects are not built in correct order and app is unable to consume library's generated resource files, the app's build fails

Failure Logs

see above

Other

see above

[dherges]

Current behaviour of affected:build --base=[SHA] --head=[SHA] is:

$ yarn affected:build --base=$(git rev-parse HEAD~1) --head=$(git rev-parse HEAD)
yarn run v1.15.2
$ ./node_modules/.bin/nx affected:build --base=cc45369be04e2a9425bb8eb91bdc91520095cbcc --head=5626d04aa607811cfba523959203d18c3f7b24be
Running build for projects:
  shared,
  foobar
Running build for shared
Running build for foobar
Running build for affected projects succeeded.

[dherges]

Pull Request for Nx 7: #1318

Pull Request for Nx 8: #1317

[github-actions]

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.