-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Files with parentheses fails format. #1473
Comments
FrozenPandaz
added
community
This is a good first issue for contributing
type: bug
labels
Jun 11, 2019
It would be great if you could open a PR to fix this issue 👍 |
ZachJW34
added a commit
to ZachJW34/nx
that referenced
this issue
Jun 12, 2019
Files that contained parentheses caused 'yarn format' to fail unless the files passed to the prettier cli are wrapped in quotes fix nrwl#1473
ZachJW34
added a commit
to ZachJW34/nx
that referenced
this issue
Jun 12, 2019
Files that contained parentheses caused 'yarn format' to fail unless the files passed to the prettier cli are wrapped in quotes fix nrwl#1473
ZachJW34
added a commit
to ZachJW34/nx
that referenced
this issue
Jun 12, 2019
Files that contained parentheses caused 'yarn format' to fail unless the files passed to the prettier cli are wrapped in quotes fix nrwl#1473
ZachJW34
added a commit
to ZachJW34/nx
that referenced
this issue
Jun 14, 2019
Files that contained parentheses caused 'yarn format' to fail unless the files passed to the prettier cli are wrapped in quotes fix nrwl#1473
vsavkin
pushed a commit
that referenced
this issue
Jun 15, 2019
Files that contained parentheses caused 'yarn format' to fail unless the files passed to the prettier cli are wrapped in quotes fix #1473
This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Prerequisites
Expected Behavior
Files with parentheses in them should be formatted as normal
Current Behavior
Files that contain parentheses e.g
some(file).json
cause formatting to fail.Failure Information
Parentheses in a shell command throw a syntax error. The nx format scripts pass in the list of affected files to prettier via
execSync
without escaping parentheses or wrapping the file path in quotes. The error thrown is:Steps to Reproduce
yarn create nx-workspace myworkspace
cd myworkspace
touch some\(file\).json
git add .
git commit -m "testing"
yarn format --base HEAD~1 --head HEAD
Context
Tested with Nx version 8:
The relevant code can be found here.
I'd be happy to submit a PR to fix this so let me know.
The text was updated successfully, but these errors were encountered: