Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @types/react-router-dom when generating react routing #1557

Closed
FrozenPandaz opened this issue Jul 4, 2019 · 2 comments · Fixed by #1762
Closed

Add @types/react-router-dom when generating react routing #1557

FrozenPandaz opened this issue Jul 4, 2019 · 2 comments · Fixed by #1762
Assignees
@jaysoo
Labels
blocked: third-party community This is a good first issue for contributing outdated type: enhancement

Comments

@FrozenPandaz
Copy link
Collaborator

Expected Behavior

@types/react-router-dom is not installed when I generate a @nrwl/react application.

Current Behavior

@types/react-router-dom should be installed when I generate a @nrwl/react application. We can also add it during ng add @nrwl/react.

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. npx create-nx-workspace@latest react-test --preset empty
  2. ng add @nrwl/react
  3. `ng g @nrwl/react:app my-app
@FrozenPandaz FrozenPandaz added community This is a good first issue for contributing type: enhancement labels Jul 4, 2019
@FrozenPandaz FrozenPandaz modified the milestone: next Jul 4, 2019
@jaysoo
Copy link
Member

jaysoo commented Jul 17, 2019

We need to wait for the types to be updated, or help update them.

DefinitelyTyped/DefinitelyTyped#36368

jaysoo added a commit to jaysoo/nx that referenced this issue Aug 28, 2019
@jaysoo
feat(react): add react-router-dom types
ab5205b 
Closes nrwl#1557
@jaysoo jaysoo mentioned this issue Aug 28, 2019
Merged
jaysoo added a commit that referenced this issue Aug 28, 2019
@jaysoo
feat(react): add react-router-dom types (#1762)
989e566 
Closes #1557
@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jaysoo jaysoo

Labels
blocked: third-party community This is a good first issue for contributing outdated type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(react): add react-router-dom types jaysoo/nx
2 participants
@jaysoo @FrozenPandaz