Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm scripts documentation is incorrect #1567

Closed
BuckyMaler opened this issue Jul 7, 2019 · 1 comment · Fixed by #1690
Closed

npm scripts documentation is incorrect #1567

BuckyMaler opened this issue Jul 7, 2019 · 1 comment · Fixed by #1690

Comments

@BuckyMaler
Copy link
Contributor

Expected Behavior

The npm scripts documentation should list only available options for each script/command.

Current Behavior

The npm scripts documentation lists options that aren't available for scripts/commands. For example, many of the options listed in the workspace schematic doc aren't and shouldn't be available to that script/command.

BuckyMaler added a commit to BuckyMaler/nx that referenced this issue Jul 7, 2019
Before, a single instance of yargs was accumulating options, so commands parsed later would have options from prior commands. That's because all yargs options are global by default. Now, a new instance of yargs is required before each command is parsed, so global options aren't accumulated.

fixes nrwl#1567
BuckyMaler added a commit to BuckyMaler/nx that referenced this issue Jul 7, 2019
Before, a single instance of yargs was accumulating options, so commands parsed later would have options from prior commands. That's because all yargs options are global by default. Now, a new instance of yargs is required before each command is parsed, so global options aren't accumulated.

fixes nrwl#1567
BuckyMaler added a commit to BuckyMaler/nx that referenced this issue Jul 8, 2019
Before, a single instance of yargs was accumulating options, so commands parsed later would have options from prior commands. That's because all yargs options are global by default. Now, a new instance of yargs is required before each command is parsed, so global options aren't accumulated.

fixes nrwl#1567
BuckyMaler added a commit to BuckyMaler/nx that referenced this issue Jul 20, 2019
Before, a single instance of yargs was accumulating options, so commands parsed later would have options from prior commands. That's because all yargs options are global by default. Now, a new instance of yargs is required before each command is parsed, so global options aren't accumulated.

fixes nrwl#1567
vsavkin pushed a commit to vsavkin/nx that referenced this issue Aug 6, 2019
Before, a single instance of yargs was accumulating options, so commands parsed later would have options from prior commands. That's because all yargs options are global by default. Now, a new instance of yargs is required before each command is parsed, so global options aren't accumulated.

fixes nrwl#1567
vsavkin pushed a commit that referenced this issue Aug 6, 2019
Before, a single instance of yargs was accumulating options, so commands parsed later would have options from prior commands. That's because all yargs options are global by default. Now, a new instance of yargs is required before each command is parsed, so global options aren't accumulated.

fixes #1567
@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants