-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement custom module federation config path in angular/src/builders/utilities/module-federation.ts #15739
Comments
If you're willing to implement this, feel free to open a PR. There's also a chance you'll need to ensure the executor/builder will be able to handle the import of TS file correctly. |
Okay thanks. I will start to work on it as soon as possibile, hope to do my best to contribute to the project :) |
added an option to make the module-federation-dev-server and ssr builder accept a custom path for the module federation config file. Closes nrwl#15739
added an option to make the module-federation-dev-server and ssr builder accept a custom path for the module federation config file. Closes nrwl#15739 feat(angular): custom mf config path and ts support added a path to retrieve the module-federation.config file and to support typescript config file Closes nrwl#15739 docs(angular): autogenerated docs for custom mf config path fix(angular): runned nx format after custom mf config path changes
added an option to make the module-federation-dev-server and ssr builder accept a custom path for the module federation config file. added a path to retrieve the module-federation.config file and to support typescript config file Closes nrwl#15739
Handle TS mf config file in Webpack withModuleFederation stable + renamed schema prop. and fixes from review on PR nrwl#16299 Close(nrwl#15739)
Handle TS mf config file in Webpack withModuleFederation stable + renamed schema prop. and fixes from review on PR nrwl#16299 Close(nrwl#15739)
added an option to make the module-federation-dev-server and ssr builder accept a custom path for the module federation config file. added a path to retrieve the module-federation.config file and to support typescript config file Closes nrwl#15739
Handle TS mf config file in Webpack withModuleFederation stable + renamed schema prop. and fixes from review on PR nrwl#16299 Close(nrwl#15739)
This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context. |
Description
Currently, the Nx Angular Module Federation Dev Server when calling the getStaticRemotes method use the default path for the module-federation.config(in project root folder 'module-federation.config.js'), which can be inconvenient in certain scenarios and make unable to use a typescript config file(like my module-federation.config.ts). It would be helpful to have the ability to specify a custom path for the module-federation.config file when starting the dev server. This would allow users to load the config from a specific location(ex. a libs containing all the manifest) and to use a ts config.
Motivation
Implementing a custom module-federation.config path in the Nx Angular Module Federation Dev Server would provide more flexibility, capabilities to use typed config file and convenience for users who need to work with it in non-standard scenarios.
Suggested Implementation
The text was updated successfully, but these errors were encountered: