Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nx): use same prettier version #1869

Merged
merged 1 commit into from
Sep 23, 2019
Merged

fix(nx): use same prettier version #1869

merged 1 commit into from
Sep 23, 2019

Conversation

mehrad-rafigh
Copy link
Contributor

Current Behavior (This is the behavior we have today, before the PR is merged)

prettier is installed in two different version. (1.16.4 and 1.18.2)

Expected Behavior (This is the new behavior we can expect after the PR is merged)

prettier is installed with the same version (1.18.2)

Issue

Closes #1863

@catfireparty
Copy link
Contributor

Am I right in thinking this simply updates the internal version of prettier rather than does anything clever like checking for a more up to date locally installed version?

There's a lot of formatting noise in this PR unfortunately :(

(Do we have an agreed line length? A lot of these changes seem to be consolidating multiple lines onto a single line...)

@mehrad-rafigh
Copy link
Contributor Author

mehrad-rafigh commented Sep 23, 2019

Hi @jdpearce. Thank you for your review. Yes you are right. I am not doing any clever checking, because the last PR actually should have done this. See here
This PR just updates the prettier version of nrwl to reflect the same version used here

But you are right, this PR collapses multiple lines into a single one.
As for the line length, there is no limitation in the .prettierrc, thus falling back to prettier's standard line length of 80 characters.

@catfireparty
Copy link
Contributor

I'm going to merge this - if we need to do anything cleverer we can raise another issue :)

@catfireparty catfireparty merged commit e6b07e2 into nrwl:master Sep 23, 2019
Doginal pushed a commit to Doginal/nx that referenced this pull request Oct 30, 2019
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: use installed prettier version
2 participants