-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nx): update workspace to use prettier v1.18.2 #1809
Conversation
The commit message is not correct, thus breaking the build. I would recommend renaming your commit to Additionaly, the new prettier version should be used, when generating new apps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update packages/workspace/src/utils/versions.ts
accordingly
@wimzyLive Thank you very much for your PR! Could you squash the commits and change the message to @mehrad-rafigh Thank you for helping out folks contributing to the repo. Just wanted to say that we use |
@vsavkin fixed. |
@vsavkin thanks for the correction 👍 |
@wimzyLive Thank you! |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
format:check
withnx@latest
fails when there is a pair of () around async pipes in HTMLCurrent Behavior
Currently latest nx workspace defaults to prettier version 1.16.2, whereas latest version of prettier-vscode uses 1.18.x.
In prettier 1.16.x prettier adds () around async pipes in HTML. i.e.
<div *ngIf="(isRendered | async)"></div>
In prettier 1.17 this behaviour was updated to not to have () around pipes. i.e.
<div *ngIf="isRendered | async"></div>
Current prettier-vscode uses 1.18 so it removes () around pipes, but when running
format:check
, nx expects () around pipes because of it using prettier 1.16.Reference to prettier issue
Expected Behavior
This change updates prettier version to 1.18 same as prettier-vscode to resolve this conflicting behaviour.